Skip to content

fix: fix SuperComponent class serialization/deserialization for async Pipelines#9527

Merged
anakin87 merged 5 commits intomainfrom
supercomponent-async-serialization
Jun 18, 2025
Merged

fix: fix SuperComponent class serialization/deserialization for async Pipelines#9527
anakin87 merged 5 commits intomainfrom
supercomponent-async-serialization

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jun 17, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • added a new serialization parameter is_pipeline_async to the serialized dictionary of SuperComponent to store this information
  • use this parameter to choose the appropriate pipeline class during deserialization

How did you test it?

CI, new unit test

Notes for the reviewer

In case this information is missing, we default to sync Pipeline: this should make sure that deserialization does not break for SuperComponents serialized before we release this change.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 marked this pull request as ready for review June 17, 2025 14:03
@anakin87 anakin87 requested review from a team as code owners June 17, 2025 14:03
@anakin87 anakin87 requested review from dfokina and sjrl and removed request for a team June 17, 2025 14:03
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15727395340

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 90.145%
Files with Coverage Reduction New Missed Lines %
core/super_component/super_component.py 1 95.92%
Totals Coverage Status
Change from base Build 15727109961: 0.002%
Covered Lines: 11553
Relevant Lines: 12816
💛 - Coveralls

sjrl
sjrl approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@anakin87 anakin87 enabled auto-merge (squash) June 18, 2025 08:07
@anakin87 anakin87 merged commit a16ee96 into main Jun 18, 2025
19 checks passed
@anakin87 anakin87 deleted the supercomponent-async-serialization branch June 18, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina was automatically assigned from deepset-ai/documentation

Assignees

No one assigned

Labels

topic:core topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update SuperComponent to specify if Pipeline or AsyncPipeline should be used in from_dict

3 participants

@anakin87 @coveralls @sjrl